Skip to content

Fixing cokery selection (and modules)#13

Open
kevmert wants to merge 4 commits intoBlu3wolf:masterfrom
kevmert:master
Open

Fixing cokery selection (and modules)#13
kevmert wants to merge 4 commits intoBlu3wolf:masterfrom
kevmert:master

Conversation

@kevmert
Copy link

@kevmert kevmert commented Sep 13, 2016

In the process of trying to fix the cokery because I couldn't select it with the deconstruction planner or the blueprint planner, I messed with some of the code, I've tested it in 14.3 and multiplayer with 2 others, and my changes to these files have appeared to have fixed all the problems I've been having with the cokery and also some of the code that seems to not be working properly with the modules in some of the buildings.

@kevmert
Copy link
Author

kevmert commented Sep 24, 2016

I don't know if you have had time to look at this yet, but if it has something to do with my changes, I'm still learning, so could you let me know what I did wrong?

@Blu3wolf
Copy link
Owner

Ive just not had the time to look over it sorry. Im not really using Factorio at present, and with exams coming up Ive not really had the time to play with this either.
Unfortunately that is not real likely to change in the near future either, which is why I added @StephenWard as a manager for the Treefarm repositories.
If I do get the time, Ill have a look and let you know if there is a problem, and if there is not one, Ill merge the request. I cant just merge it without assessing it and testing it, though.

@Blu3wolf
Copy link
Owner

Can someone looking at #8 take a look at this and let me know if it should be merged? Cheers.

@Blu3wolf
Copy link
Owner

Blu3wolf commented Nov 9, 2017

Alright, so walk me through the changes made - you have eliminated the dummy entity, and changed the get_surface to surfaces? Looks okay, but Im not up close and personal with the code. I assume this has been tested?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants